pyflakes icon indicating copy to clipboard operation
pyflakes copied to clipboard

Remove universal wheel, python 2 is unsupported

Open gopackgo90 opened this issue 2 years ago • 5 comments

gopackgo90 avatar Aug 14 '22 21:08 gopackgo90

I use this marker as a "is pure python" -- we use python_requires which is the actual metadata that controls this

asottile avatar Aug 14 '22 22:08 asottile

What do you think about this?:

[bdist_wheel]
python-tag = py3

I guess I'm not sure if universal = 1 is some sort of magic "pure python" marker. I'm not familiar with that idea.

gopackgo90 avatar Aug 14 '22 22:08 gopackgo90

yeah universal means single source pure python

asottile avatar Aug 14 '22 23:08 asottile

https://peps.python.org/pep-0425/#id1

a user might accept only the *-none-any tags to only download built packages that advertise themselves as being pure Python.

If you were to drop the universal flag the file the wheel would be "pyflakes-x.y.z-py3-none-any.whl" instead of "pyflakes-x.y.z-py2.py3-none-any.whl", so the "-none-any" in there still seems to be how PEP 425 defines a pure python wheel.

gopackgo90 avatar Aug 14 '22 23:08 gopackgo90

yes however that isn't known statically, and the py2 part is harmless

asottile avatar Aug 15 '22 00:08 asottile