pyflakes
pyflakes copied to clipboard
PyCQA
Catch usage of undefined name with global statement
@sigmavirus24 it seems the CI is failing not because of the test. Can you look at it?
ah. sorry, I didn't know that it's error of flake8 please ignore the above comment
Also please add the test from the original issue to make sure the problem is corrected.
@adhikasp, I've already added. check the commit message.
I've already added. check the commit message.
You mean this one? https://github.com/PyCQA/pyflakes/pull/324/commits/fdf2353d4b53c4c1305ed80e31ea6252845c6f26#diff-44d7abf892e78127bd9438c51e1cfd49R340
But this is different compared to the snippet in the original issue. There should be another test when a function have args with same name as a global variable declared inside it. The function in your test above doesn't receive any argument.
Yeah, the GCI task I specified is different to #249. The one I specified matches the test case @seeeturtle created.
def main():
global x
print(x)
main()
So I think @adhikasp's comment about the test doesn't apply.
(Actually, #249 would have been easier. I probably should have specified that case for the GCI task.)
Hello, @myint, I just found that this PR hasn't merged for a while. Is there any problem?
@seeeturtle One of the other PyCQA members needs to approve this before I can merge it. This is the case for several of the open pull requests.
Ah, I got it. Thanks
-
-
- 오전 1:16 Steven Myint [email protected] 작성:
-
@seeeturtle One of the other PyCQA members needs to approve this before I can merge it. This is the case for several of the open pull requests.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
