modernize icon indicating copy to clipboard operation
modernize copied to clipboard

Raise with string and format operator is fixed incorrectly

Open dwvisser opened this issue 6 years ago • 2 comments

This is similar to issue #180, which appears to have been closed without any justification given. Here's the relevant portion of the output of python-modernize (v0.7) which illustrates the bug:

--- test_modernize_formatted_raise.py	(original)
+++ test_modernize_formatted_raise.py	(refactored)
@@ -1,4 +1,4 @@
 def hello(name, language):
     if language is None:
-        raise('Language for %s not defined' % name)
+        raise 'Language for %s not defined'
     pass

dwvisser avatar Jul 29 '19 15:07 dwvisser

I see that in Python 3 that raise has been changed to only accept a single argument, which must be an expression that resolves to something that is BaseException or derived from it. I think that python-modernize should emit warning messages at least on these refactorings.

dwvisser avatar Jul 29 '19 18:07 dwvisser

Wow. Yeah, that's really broken code :/...

ngie-eign avatar Aug 23 '19 02:08 ngie-eign