Args parsing priority changed
ini file goes first, if it's empty, then command-line arguments passed.
After your last MR, arguments from file are not taken (https://github.com/PyCQA/bandit/commit/c6b1302e7b1ab1ad78799264d8ca7222f2c3d428) My small patch fixes this.
What do you think?
I changed the order because currently "--ini INI_PATH" option is not working anymore with your latest change. https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L225 (takes default values) https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L311 (passes default values) https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L82 (breaks "--ini" parameter logic here) Do you have any suggestions?
I changed the order because currently "--ini INI_PATH" option is not working anymore with your latest change. https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L225 (takes default values) https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L311 (passes default values) https://github.com/PyCQA/bandit/blob/master/bandit/cli/main.py#L82 (breaks "--ini" parameter logic here) Do you have any suggestions?
Yeah, we need to fix or revert my patch if it's now breaking existing function.