PyAV icon indicating copy to clipboard operation
PyAV copied to clipboard

AVFormat property start_time_realtime available in input container.

Open karoldob opened this issue 3 years ago • 4 comments

start_time_realtime is useful if you want to synchronize multiple video streams.

karoldob avatar Apr 26 '22 12:04 karoldob

Let's have a docstring + a unit test for this new property.

jlaine avatar Apr 26 '22 14:04 jlaine

Sorry I had some issues with identites. Docs, tests are ready

karoldob avatar Apr 26 '22 18:04 karoldob

Ouch I hadn't fully thought through my request for a unit test for this.. We already have a ticket complaining our test suite depends on network access, and this only makes this even more true!

jlaine avatar Apr 27 '22 09:04 jlaine

Hi @jlaine all your suggestions are fixed. It looks label 'change requested` could be removed :) Anything other blocks this merge?

karoldob avatar Jul 12 '22 12:07 karoldob

@karoldob what was blocking was my lack of time :) I've rebased your code on top of master, with a slightly reworded docstring. Let's see how CI goes, I'm hoping to get this in for the next release which should be very soon.

jlaine avatar Oct 17 '22 15:10 jlaine

Hm, it looks as though rtsp.stream is no longer available. That might be for the best, as increasing our dependency on "having network access" is not something I was looking forward to. I wonder if we can spin up our own RTSP server using PyAV?

jlaine avatar Oct 17 '22 15:10 jlaine

This commit doesn't work anymore and don't care about this enough to fix it myself, so I will be closing.

WyattBlue avatar Nov 25 '23 08:11 WyattBlue