PyAV icon indicating copy to clipboard operation
PyAV copied to clipboard

Allow setting the max_bit_rate and min_bit_rate in codec context

Open hmaarrfk opened this issue 2 years ago • 4 comments

These variables are documented as part of ffmpeg.

It might be useful for others to read and write them.

hmaarrfk avatar Jan 11 '23 17:01 hmaarrfk

OK could we have a test for this please?

The CI failure should go away if you rebase on top of the latest code.

jlaine avatar Jan 23 '23 07:01 jlaine

I'm actually no longer sure what should happen when these things change. I had to specificy the codec context options dictionary to have a visible change in my output quality.

hmaarrfk avatar Jan 23 '23 11:01 hmaarrfk

I'm guessing this PR hasn't been rebased yet as the new tests are against pypy3.9 and not pypy3?

jlaine avatar Jan 23 '23 16:01 jlaine

I've rebased the patch, but I'm not sure what effect "writing" to these two properties has.

hmaarrfk avatar Jan 24 '23 02:01 hmaarrfk

This PR is too old.

WyattBlue avatar Mar 05 '24 05:03 WyattBlue