AlgorithmsAndDataStructure icon indicating copy to clipboard operation
AlgorithmsAndDataStructure copied to clipboard

Added def function for converting Integer to Roman

Open Techkrish1 opened this issue 2 years ago • 2 comments

Pull Request Template

What have you Changed(must)

I implemented Integer to Roman. I tested with flack8. I spent more than 1 hour. Please review it.

Write here what you have changed in codebase

Issue no.(must) - #808

Pr will be closed and marked as spam. If issue number not found or issue was assigned to someone else. Marking as spam can block your account from HacktoberFest.

Self Check(Tick After Making pull Request)

  • [ ] This issue was assigned to me if not it will marked as spam.
  • [ ] My file is in proper folder
  • [ ] I am following clean code and Documentation.My code is well linted and I am using flake8 standard for python
  • [ ] I have added title and what program will do first in the file

README - How to Contribute

Techkrish1 avatar Aug 20 '22 14:08 Techkrish1

what is this and how can I lint with flake8? image

Techkrish1 avatar Aug 20 '22 14:08 Techkrish1

issues is mentioned in your picture, like whitespace or line length, please check on flake8 documentation for details.

codeperfectplus avatar Aug 20 '22 15:08 codeperfectplus