pokemon-data.json
pokemon-data.json copied to clipboard
Add French name in /Items.json
Description
Add jname (Japanese name), cname (Chinese name (simplified)) and fname(Frech name) to items.json to make it consistent with the rest of the database.
The required structure:
From:
{
"id": 1,
"ename": "Master Ball",
"type": "Pokeballs",
"description": "The best Ball with the ultimate level of performance. It will catch any wild Pokémon without fail."
}
To:
{
"id": 1,
"name": {
"english": "Master Ball",
"japanese": "マスターボール",
"chinese": "大师球",
"french": "Master Ball"
}
"type": "Pokeballs",
"description": "The best Ball with the ultimate level of performance. It will catch any wild Pokémon without fail."
}
Tasks :
~- [ ] To add jname, cname and fname~
- [x] Change
namestructure - [x] To add
jname - [x] To add
cname - [ ] To add
fname
Please mention this issue in your PR (#7) and add the above to-do in the PR as well
Comment below if you would like to claim this issue, please do not start working on the issue unless assigned to you explicitly
I would like to contribute!
I would like to contribute!
Sure go ahead
@Karim-Adnan Please refer to the updated structure
alright
cname and jname already added, only french name left