pokemon-data.json icon indicating copy to clipboard operation
pokemon-data.json copied to clipboard

Add French name in /Items.json

Open Purukitto opened this issue 5 years ago • 6 comments

Description

Add jname (Japanese name), cname (Chinese name (simplified)) and fname(Frech name) to items.json to make it consistent with the rest of the database.

The required structure:

From:

{
    "id": 1,
    "ename": "Master Ball",
    "type": "Pokeballs",
    "description": "The best Ball with the ultimate level of performance. It will catch any wild Pokémon without fail."
}

To:

{
    "id": 1,
    "name": {
        "english": "Master Ball",
        "japanese": "マスターボール",
        "chinese": "大师球",
        "french": "Master Ball"
    }
    "type": "Pokeballs",
    "description": "The best Ball with the ultimate level of performance. It will catch any wild Pokémon without fail."
}

Tasks :

~- [ ] To add jname, cname and fname~

  • [x] Change name structure
  • [x] To add jname
  • [x] To add cname
  • [ ] To add fname

Please mention this issue in your PR (#7) and add the above to-do in the PR as well

Comment below if you would like to claim this issue, please do not start working on the issue unless assigned to you explicitly

Purukitto avatar Sep 27 '20 13:09 Purukitto

I would like to contribute!

Karim-Adnan avatar Sep 27 '20 14:09 Karim-Adnan

I would like to contribute!

Sure go ahead

Purukitto avatar Sep 27 '20 14:09 Purukitto

@Karim-Adnan Please refer to the updated structure

Purukitto avatar Sep 29 '20 06:09 Purukitto

alright

Karim-Adnan avatar Oct 02 '20 14:10 Karim-Adnan

cname and jname already added, only french name left

Purukitto avatar Oct 24 '20 16:10 Purukitto