IMDb-Scout-Mod icon indicating copy to clipboard operation
IMDb-Scout-Mod copied to clipboard

Add support for a 2nd Radarr instance

Open Zevell opened this issue 1 year ago • 1 comments

This is the pull request for #221. Please double-check the imdb_scout sections, I had to increment the numbers as I explained in the discussion but I am not entirely sure why that fixed the issue with icons not loading.

I did not add support for a 2nd instance of Sonarr. I may create a pull request for that in the future, but it is unlikely at the moment, as I personally only use a 2nd instance of Radarr.

I tried briefly to add custom tooltip support for both instances of Radarr, but it was presenting issues, so I decided to just submit it in its current form with the tooltip being "Radarr2" as I believe that is sufficient for now.

I have only tested on Firefox, but since the spacing and everything was copied from the original Radarr implementation, I don't think there should be any issues.

Zevell avatar Jun 05 '24 16:06 Zevell

I had to increment the numbers as I explained in the discussion but I am not entirely sure why that fixed the issue with icons not loading.

When you added the new section for Radarr2 all the sections below it moved by +1, so the code where it loads icons to the sections with sites were off by 1 digit. For example here is where a section is set: https://github.com/Purfview/IMDb-Scout-Mod/blob/195068020b05d780e0a8ee6f9be637709e6f7c2a/IMDb_Scout_Mod.user.js#L10715

Later I'll review the PR when I'll have time.

Purfview avatar Jun 05 '24 17:06 Purfview