Davide Punzo

Results 116 comments of Davide Punzo

@lassoan I have applied your last feedback in https://github.com/Slicer/Slicer/pull/6662/commits/d38e9ceff02f1fdff328eddbf06d1a05391f2ea4 This is ready for another review iteration if needed. Thanks!

@lassoan, thanks for retesting! I have fixed the last issues in https://github.com/Slicer/Slicer/pull/6662/commits/c232eae964b24400069ce5a8c4d7abaaa890a76d: > It is almost there. A few comments: > > * It is a bit confusing that all...

> Thanks for working on this. I feel that the whole job stopping mechanism is quite fragile. See more details in inline comments. Hei Andras, thanks for reviewing. The jobs...

> Thank you Davide, this is so much better! Still, there are a few things that would be nice to clarify - see comments inline. thank you for reviewing!!! I...

> Thanks for the update. you are welcome! > I've added a couple of more comments inline. ok I have applied them see https://github.com/commontk/CTK/pull/1191/commits/045cb41959b7b5b2ba2832b8d2562faef94d85ae > In addition to that, it...

> Thank you, the changes look good to me. thanks for reviewing and merging. Slicer PR is at https://github.com/Slicer/Slicer/pull/7650

> * Huge amount of DICOM communication log is printed on the console. It can cause very significant delays, so the amount should be configurable (we can use `DICOM/detailedLogging` application...

For reference: Error report is addressed in the following PR: * https://github.com/commontk/CTK/pull/1184.

> * [ ] Finalize and publish discourse post: https://hackmd.io/SFrAGE4CS8uSkI2YvDRKRg?both I have done my last edit. @lassoan it would be nice if you can review (specifically the intial sentence regarding...

@lassoan, thanks for the text edits and I have applied yout comments in https://hackmd.io/SFrAGE4CS8uSkI2YvDRKRg?both. I am going to post it now on the Slicer forum @jcfr can you remove or...