Davide Punzo

Found the issue. The wado parser in cornerstoneWADOImageLoader sends a XMLHttpRequest as type=application/octet-stream; transfer-syntax=* Then it uses the mime information from the server response to guess the transfer syntax of...

@fedorov moving this back in Progress

open PR with fix at https://github.com/cornerstonejs/cornerstoneWADOImageLoader/pull/477

All relevant links on seg tol (logic, UI, etc.) https://github.com/OHIF/Viewers/issues/2918 https://github.com/dcmjs-org/dcmjs/pull/304/files generateToolState https://github.com/dcmjs-org/dcmjs/blob/master/src/adapters/Cornerstone/Segmentation_4X.js#L274 https://github.com/OHIF/Viewers/blob/e0fb439e988ad653f9af42b7424fc30bb2c0d279/extensions/dicom-segmentation/src/getOHIFDicomSegSopClassHandler.js#L160 https://github.com/OHIF/Viewers/blob/e0fb439e988ad653f9af42b7424fc30bb2c0d279/extensions/dicom-segmentation/src/getOHIFDicomSegSopClassHandler.js#L65 https://github.com/OHIF/Viewers/blob/e0fb439e988ad653f9af42b7424fc30bb2c0d279/extensions/dicom-segmentation/src/components/SegmentationSettings/SegmentationSettings.js#L139 Change message that you can see in video in https://github.com/OHIF/Viewers/pull/2924

@fedorov supporting fractional segmentations is rather complicated and it would involve various steps: 1) for cornerstone2D we need to modify the [segmentation tools](https://github.com/cornerstonejs/cornerstoneTools/tree/master/src/store/modules/segmentationModule) infrastructure to allow rendering each segment with...

Ok I will check the actual values in the array. In case, should I use a simple thresholding for binarizing them? I fear anything more convoluted can be slow in...

PR with summary of my findings is here: https://github.com/dcmjs-org/dcmjs/pull/309 @pieper @fedorov

@sedghi can you please review this? thanks!

> see my comments, refactoring needed @sedghi thanks for the review! I have refactored and applied your comments in https://github.com/cornerstonejs/cornerstoneWADOImageLoader/pull/477/commits/55628dd0ed4ef2b8d77cd6cb3394f9ba264ad5e6

@sedghi applied last comment in https://github.com/cornerstonejs/cornerstoneWADOImageLoader/pull/477/commits/213db6ad978de32cadc5cc7a2b9d17482c313fee