Davide Punzo
Davide Punzo
we need to test, it looks like the images get a shift, so it is not a panning of the camera. Steps to reproduce: go to https://dev-slim-viewer.canceridc.dev/studies/1.3.6.1.4.1.5962.99.1.2440258434.818002713.1625937929090.3.0/series/1.3.6.1.4.1.5962.99.1.2440258434.818002713.1625937929090.2.0 zoom at the...
@hackermd maybe a bug in static method deriveImageGeometry? https://github.com/MGHComputationalPathology/dicom-microscopy-viewer/blob/3b6b5afaae419e2f006e90fba297ad9612de6a8a/src/channel.js#L451
I perfomed further testing on this. In the following video we can see that the "image shift" occurs only when the tile do a transition between "preview" (i.e. when is...
> Thanks for investigating further @Punzo. We'll need to discuss what priority this has. So far it's been stated by @dclunie that this wouldn't be acceptable for clinical pathology review...
> don't stop working on this ... there is clearly a problem that needs to be fixed, regardless of the user ... it's not annoying, it's unprofessional we will definitely...
So summing up OpenLayers dev told us: 1) the lower resolution tiles are used on higher resolution levels only during the donwload and they are upsampled. 2) to upsample they...
> Can it really be a problem with the tiles, base layer or downsampled, if the supplied tiles (not the OpenLayers upsampled ones) display correctly (in the correct locations)? Since...
@dclunie @hackermd this should fix the issue https://github.com/MGHComputationalPathology/dicom-microscopy-viewer/pull/73. It looks like OpenLayer does not accept "zoom" factors (resolutions) in the Grid which are not integer (which makes 100% sense). I...
@pieper @cpinter reference discussion: https://discourse.slicer.org/t/dicom-database-update-is-requested-after-new-slicer-version-but-appears-to-be-impossible/35821/18
I'm not completely familiar with this specific part of codebase of the cktDICOMDatabase, so this PR was just a quick fix following the discussion on https://discourse.slicer.org/t/dicom-database-update-is-requested-after-new-slicer-version-but-appears-to-be-impossible/35821/18. The idea wasn't to...