Puneet

Results 49 comments of Puneet

Is there a reason for not adding `Apple Color Emoji` as mentioned here https://github.com/Expensify/App/issues/10356#issuecomment-1213429783.

### Proposal `Apple Color Emoji` can fix this for mac but this issue is at other platforms too (android app and mWeb) So instead of adding another font we have...

> @Puneet-here While your proposed solution might work to replace the emojis with the relevant symbols, it lacks details on: > > 1. Which source are you going to rely...

> Considering the number of emojis to be checked? Can we either list down the problematic emojis or have a programmatic way to identify the problematic emojis? I don't think...

### Proposal We just have to return ```js `${newText} ` ``` https://github.com/Expensify/App/blob/2174ef50cd16fb3da074ef5dce880ac1653e7d23/src/libs/EmojiUtils.js#L201

@adeel0202, proposals can be posted any time after the issue gets created. Please refer [here](https://github.com/Expensify/App/issues/10990#issuecomment-1249790443).

### Updated proposal Check the `emojiData.length` ```js if (emojiData.length > 1) { return newText; } return `${newText} `; ``` https://github.com/Expensify/App/blob/2174ef50cd16fb3da074ef5dce880ac1653e7d23/src/libs/EmojiUtils.js#L201

### Proposal We need to keep the max lines 6 for isSmallScreenWidth and 16 when it's false https://github.com/Expensify/App/blob/f84651934726d25e720047839c4ed750eea111b6/src/pages/home/report/ReportActionItemMessageEdit.js#L201 ``` maxLines={this.props.isSmallScreenWidth ? 6 : 16} ``` we can keep add them...

> @Puneet-here question: In message edit, why is the max line height 6 for native? Shouldn't it be 16 because we're setting it over here? It's probably because of the...