[WIP] Implement `execute-dir`
This PR implements the execute-dir option in project, by cd'ing to the appropriate directory on refresh.
TODOs:
- [ ] More reliable way of getting the project root directory
- [ ] Tests
This works well enough for my purposes - what would be needed to get it over the finish line?
Thanks for looking into this @asinghvi17.
what would be needed to get it over the finish line?
Some tests to verify the new behaviour will be needed.
Codecov Report
Attention: Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
Project coverage is 50.96%. Comparing base (
899d41a) to head (3cffbfb).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/QuartoNotebookWorker/src/refresh.jl | 0.00% | 14 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 51.40% 50.96% -0.45%
==========================================
Files 30 30
Lines 1280 1295 +15
==========================================
+ Hits 658 660 +2
- Misses 622 635 +13
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@asinghvi17 do you plan on returning to the PR in the near future?
Yes, I'm on the road right now but will try to clean it up and add a test next week!
@asinghvi17 reckon you'll have a chance to finish this one up? If not that's fine, I'll put it back on the list of things for me to do.
Friendly bump, would love to see this getting merged.
Will need a rebase onto current main. Let me know if there's any further questions you have @asinghvi17.