PufferLib icon indicating copy to clipboard operation
PufferLib copied to clipboard

Documentation request for Protein

Open ad8e opened this issue 9 months ago • 1 comments

What should I do about the init parameters? Do I know any properties of my problem that would cause them to change, or are these defaults attempted optimal in all cases? https://github.com/PufferAI/PufferLib/blob/1f5e6b0e12cbb31c503ef85a72ed708cc7f0ff58/pufferlib/sweep.py#L328

Here, should I pass in my NaNs with is_failure=True? I'm not seeing where this flag is used. Or should I omit observing my NaNs? https://github.com/PufferAI/PufferLib/blob/1f5e6b0e12cbb31c503ef85a72ed708cc7f0ff58/pufferlib/sweep.py#L634

ad8e avatar Mar 29 '25 03:03 ad8e

  1. We've just been using the defaults in demo.py for a while
  2. Runs really shouldn't be failing. This was legacy from CARBS. We may or may not have this in the final version
  3. You will get replies instantly instead of whenever I happen to see issues on discord, x, stream, etc. I am very responsive but just have way too many communication channels
  4. Final version of protein with cleanups etc will be in the next major version of pufferlib

jsuarez5341 avatar Apr 21 '25 11:04 jsuarez5341

https://x.com/jsuarez5341/status/1938287195305005500

ad8e avatar Jul 01 '25 06:07 ad8e