public-tree-map icon indicating copy to clipboard operation
public-tree-map copied to clipboard

Published 20 hours ago • verified publisher icon Public-Tree-Map

Hide nominate heritage tree section if selected tree is heritage tree

Open wgnvrd opened this issue 5 years ago • 6 comments

resolves #305

What I did

if the selected tree is a heritage tree, then the link to nominate the tree will hide itself.

wgnvrd avatar Jun 21 '20 21:06 wgnvrd

thank you @isabelle-wagenvoord !

please take another look. when I test it, the nomination section still appears in the sidebar for heritage trees. the regular (placeholder) text on the landing page sidebar's also disappeared.

to find a heritage tree, you can use the "SM heritage" button. the screenshot is of tree id=10934061

Screen Shot 2020-06-21 at 3 05 25 PM Screen Shot 2020-06-21 at 3 06 27 PM

emillipede avatar Jun 21 '20 22:06 emillipede

Ah, my bad! Hopefully it should work now.

wgnvrd avatar Jun 22 '20 03:06 wgnvrd

thanks @isabelle-wagenvoord

can you please share a screenshot of how it looks when you look at the branch? when I open the index.html file, it looks the same as it did before. thank you again!

emillipede avatar Jun 23 '20 01:06 emillipede

@isabelle-wagenvoord I forgot to ask about this PR, I'm sorry! when you test it on your end, do you see the same issues I notice?

emillipede avatar Jul 02 '20 13:07 emillipede

Ah my bad @emillipede. I think I forgot to add my changes before committing them 😅. Does it work now?

wgnvrd avatar Jul 04 '20 22:07 wgnvrd

thanks for the update @isabelle-wagenvoord ! the sidebar placeholder text is visible again when I locally open this branch, but the heritage section of the sidebar still shows up for existing heritage trees

when you test the branch, does it look different to you? please let me know. I'm sorry, I don't know what's wrong :(

?id=10915056 Screen Shot 2020-07-05 at 9 44 42 PM

emillipede avatar Jul 06 '20 04:07 emillipede