TShock icon indicating copy to clipboard operation
TShock copied to clipboard

Dupe glitches

Open xaleb opened this issue 5 years ago • 5 comments

Recent Tshock Version.

So I have a user on the server who has figured out that they can duplicate items, by logging out and logging in. I use server side characters, and he leaves then waits 20 seconds. Then spawns back in. Drops items in the chest. Logs out, and logs back in to drop more items in the chest. Also Tavernkeep seems to repeatedly give out defender medals. Is there any fix to this config wise? Or is this an actual bug?

xaleb avatar May 30 '20 05:05 xaleb

Thanks for making an issue to track this. Just for the record, you should ban that guy. But yeah, definitely looking into it: https://github.com/Pryaxis/TShock/discussions/1935#discussioncomment-20176.

hakusaro avatar May 30 '20 07:05 hakusaro

The issue seems to occur due to the fact the game does not properly log them out after leaving. Which allows him to deposit the same inventory into a chest, until the server side characters save. So maybe a login limiter would be in order? Or a check to make sure the player isn't still logged in, and prevent him from joining until the previous instance of him is logged out? The guy is a friend, who figured the glitch out. So I'll have him swear to not use it until it gets fixed. Very game breaking though. The tavern keep part is just because it seems the game cant remember the player after logging out...kinda weird.

xaleb avatar May 30 '20 08:05 xaleb

Also see: https://github.com/Pryaxis/TShock/issues/1410

Olink avatar May 30 '20 16:05 Olink

@Olink big yikes on that reference -- I'm not sure if it was fixed or not (probably not?)

hakusaro avatar May 30 '20 16:05 hakusaro

soz, I mean attempted to be fixed

hakusaro avatar May 30 '20 16:05 hakusaro