TShock
TShock copied to clipboard
max player/server port/server password aren't configurable in the same manner
As mentioned here, these 3 settings are allowed to set at startup (before loading world) and config.json
though, these values won't be reflected in the same manner.
(a) max players : will use config value even if you input desired value at startup (it can be overridden by -maxplayers
command line option)
(b) server port : will use input value at startup, or use config value when -world
option is used (but -port
option overrides it)
(c) server password : won't use any value no matter what you input or set in config
(b) makes sense, but (a) is slightly confusing. (c) looks like a bug.
It's worth noting that the precedence we should follow is:
- Command line arguments take priority (because those are typically either set at runtime or before the server boots by a GSP).
- Interactive options take priority next, because a user at a console should be able to modify their config on the fly if they're booting their server. However, if command line arguments are set, those are respected above all else.
- Terraria config options should be taken into account next.
- TShock config options should be taken into account last.
@NyxStudios/tshock thoughts on this?
I agree with your earlier comment
I agree with Hakusaro's order of preference, but feel that an important 5th item exists that is merely implied instead of made an explicit part of the specification.
- (well, always last) Default settings
We should probably do this
Is this still relevant?
Yes