Jacek Pietal

Results 64 comments of Jacek Pietal

> just instead of reusing this.response and clearing it I will reinstantiate response and use its vector that way I dont have to clear, since recreating clears it, and I...

> > just instead of reusing this.response and clearing it I will reinstantiate response and use its vector that way I dont have to clear, since recreating clears it, and...

even better would be moving this to a private system function for further optimisation not to create function each checkCollision

ok I did all of that @Codezilluh can you check v6.3.10 ? also... do you have any suggestions as how to solve aInB and bInA for concave polygons ?

> > can you check v6.3.10 ? > > Works flawlessly! (as far as I can tell, and I am using pretty complex polygons) I am happy Thank you for...

I merged your MR it was great thank you! I also saw your commend about wrong aInB and bInA for non convex and I've added 1 test for the case...

hello I think I fixed that case with convex polygons having aInB and bInA screwed up after testing with concave collisions in this.collided() and this.response.reset() so I kept the state...

just add this to tsconfig.json ``` "paths": { "mini-signals": [ "node_modules/mini-signals/index.js" ] } ``` it will resolve the errors and all works in runtime too if you dont mind the...

fixed by https://github.com/Prozi/codepan/commit/713b6d63260a44093e87511936b0c109fe306c55

This https://github.com/egoist/codepan/pull/75 Pull request includes tabs as GET parameters