Support Carthage

[NghiaTranUIT]

Description

As we've already supported Cocoapod and Swift Package Manager, we should also support Carthage 👍

[pokryfka]

@NghiaTranUIT Not sure what is the status of that since README does mention Carthage https://github.com/ProxymanApp/atlantis#carthage

Regardless, it fails for me, please see details below.

Steps:

1. echo 'github "ProxymanApp/atlantis"' > Cartfile

2. carthage update --use-xcframeworks --platform iOS

Result:

*** Fetching atlantis
*** Checking out atlantis at "1.12.0"
*** xcodebuild output can be found in /var/folders/qw/5y40n2k973b2hklwn2_6rqqm0000gn/T/carthage-xcodebuild.GEP4ta.log
*** Skipped building atlantis due to the error:
Dependency "atlantis" has no shared framework schemes for any of the platforms: iOS

If you believe this to be an error, please file an issue with the maintainers at https://github.com/ProxymanApp/atlantis/issues/new

[pokryfka]

👋

[saim80]

I found this issue, too. Please support Carthage. I don't want to increase build time by adding more SPM packages.

[NghiaTranUIT]

Hey @saim80 @pokryfka since Atlantis is a pure SPM (no xcproject file), so Atlantis doesn't work well.

@saim80 please try this branch instead

github "ProxymanApp/atlantis" "feat/add-carthage"

I generated the xcproject file and it should work 👍

[NghiaTranUIT]

It's quite tricky to set up Carthage work with xcframework, so I still highly suggest using the Swift Package Manager because it's straightforward to integrate Atlantis into your project.

[stevelandeyasana]

This is marked 'done', and the README has Carthage instructions, but I still get this error message. Here's my Cartfile line:

github "ProxymanApp/atlantis" == 1.18.0

Your branch feat/add-carthage works. Can it be merged?

[NghiaTranUIT]

@stevelandeyasana It's merged and released on Atlantis 1.18.1 👍 : https://github.com/ProxymanApp/atlantis/releases/tag/1.18.1

[stevelandeyasana]

Thank you so much, works great!