Play! Core: Regression compilation (play integration)

[Spidy123222]

I'm not following issue template here only because this is kind of a montage of issues requested by JoeM to combine into one. To make it easier I will categorize this as sections.I will be using KingdomHearts and SpongeBob battle for bikini bottom for testing as these are games known to work on play and are popular titles and are in CHD format (Archival Format from Mame project) which makes no difference here. This has a comparison of two builds tested in Vulkan.

Proper working build: https://github.com/Provenance-Emu/Provenance/actions/runs/3704301328

Problem build: https://github.com/Provenance-Emu/Provenance/actions/runs/3710145447

Aspect ratio Warping

Currently when you have a game,the aspect ratio could be incorrect (ps2 aspect ratio isn't always consistent 4:3,16:9,14:9 etc) and this sometimes can cause a warping affect which looks really bad and I'm not sure this is a direct correlation to the affect but it is noticeable in game and in FMV's

Proper: https://cdn.discordapp.com/attachments/421976543506464768/1053794914971959316/IMG_5832.png

Improper: https://cdn.discordapp.com/attachments/421976543506464768/1053795076393930822/IMG_5831.png

You can see the problem on their skins here or clothing. Here is a plot twist here. The improper build seems to have fixed some graphical issues and introduced some.

Graphical bugs

Proper build: https://cdn.discordapp.com/attachments/421976543506464768/1053796237234679808/IMG_5834.png

Improper build: https://cdn.discordapp.com/attachments/421976543506464768/1053796169656062002/IMG_5835.png

Now you see here the improper build has fixed some graphical bug on bottom left but what problems come up is looking at some models like sora in this picture if you look at their joints or hood that there is some sort of glitching on the polygons able to see a little of inside. Meanwhile on the proper build the graphical problem on ground is there but sora is properly rendered. Vulkan build on play app does have the ground issue which sounds like a moltenvk issue but that's something else likely.

Texture transparency and texture issues

This is self explanatory so I'll just show the pictures.

Proper build: https://cdn.discordapp.com/attachments/421976543506464768/1053790046202892338/IMG_5830.png

Improper build: https://cdn.discordapp.com/attachments/421976543506464768/1053790037084491926/IMG_5829.png

Let's move along to one obvious picture that might freak you out but here is main menu screen of battle for bikini bottom and you can likely spot the issue. This happens on the problem build which is current atm Also.

https://cdn.discordapp.com/attachments/421976543506464768/1053798874092941402/IMG_5836.png

There is no measurable way of getting performance of them but seems like one of them hitches more often on title screen in KingdomHearts.

[Spidy123222]

Vulkan on provenance for play doesn’t seem to really be using Vulkan according to jpd themselves possibly. https://github.com/jpd002/Play-/issues/1224#issuecomment-1358706096