Applied-Energistics-2 icon indicating copy to clipboard operation
Applied-Energistics-2 copied to clipboard

[0.54.19/0.54.20] Incompatibility with the up-to-date Inventory Bogo Sorter (1.2.2)

Open NeveHanter opened this issue 2 years ago • 1 comments

Describe the bug AE2 crash after fiddling with the AE2 terminal sort by due to ABI incompatibility with up-to-date version of Inventory Bogo Sorter (1.2.2). The Bogo has changed it's code so the ITEM_COMPARATOR is no longer at the location AE2 is expecting it to be. See: https://github.com/CleanroomMC/InventoryBogoSorter/commit/29b21444ad2dbdcddca6fc09e9f5de950087171d#diff-ba4d0448ffa9f7454316cd0a4c67832e1ee958fe0504706d753099a56ca44deaL203

To Reproduce Change the sort by in AE2 terminal (couple of times, so it starts using Bogo?) and have the world immediately crash, and crash again after loading back and opening the terminal.

Expected behavior No crash and working sort with up-to-date Inventory Bogo Sorter or clear indication of no support between these two.

Additional context Crash log: https://pastes.dev/ZUeaujQdGF Excerpt with the exception:

Caused by: java.lang.NoSuchFieldError: ITEM_COMPARATOR
    at appeng.integration.modules.bogosorter.InventoryBogoSortModule.lambda$static$0(InventoryBogoSortModule.java:12)
    at java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
    at java.util.TimSort.sort(TimSort.java:234)
    at java.util.Arrays.sort(Arrays.java:1512)
    at java.util.ArrayList.sort(ArrayList.java:1464)
    at java.util.Collections.sort(Collections.java:177)
    at appeng.client.me.ItemRepo.updateView(ItemRepo.java:196)
    at appeng.client.gui.implementations.GuiMEMonitorable.postUpdate(GuiMEMonitorable.java:164)
    at appeng.container.implementations.ContainerMEMonitorable.postUpdate(ContainerMEMonitorable.java:375)
    at appeng.core.sync.packets.PacketMEInventoryUpdate.clientPacketData(PacketMEInventoryUpdate.java:145)
    at appeng.core.sync.network.AppEngClientPacketHandler$1.call(AppEngClientPacketHandler.java:50)
    at appeng.core.sync.AppEngPacket.processPacket(AppEngPacket.java:108)
    at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at net.minecraft.util.Util.runTask(SourceFile:529)
    ... 18 more

Environment Playing up-to-date nomi-ceu (1.5.0).

  • Minecraft Version: 1.12.2
  • AE2 Version: 0.54.19 / 0.54.20
  • Forge Version: 14.23.5.2860

NeveHanter avatar Feb 05 '23 17:02 NeveHanter

the new ver, can use both the same time, but while I using Inventory Bogo Sorter at the wireless crafting terminal, the item inside the inventory will disappear

skps00 avatar Dec 08 '23 11:12 skps00