proton-contacts icon indicating copy to clipboard operation
proton-contacts copied to clipboard

Missing plural

Open dhoko opened this issue 5 years ago • 2 comments

https://github.com/ProtonMail/proton-contacts/blob/8ad84cd57dc4f016982cb4301e6e77730ca9052e/src/app/components/ContactPlaceholder.js#L207

and this one https://github.com/ProtonMail/proton-contacts/blob/master/src/app/components/ContactPlaceholder.js#L196

via crowdin

dhoko avatar Oct 29 '19 15:10 dhoko

Missing plurals in updated file: https://github.com/ProtonMail/proton-contacts/blob/ae54f5caffc20c2f58c46e8a3c9e2c414fe18813/src/app/components/ContactPlaceholder.js#L169 https://github.com/ProtonMail/proton-contacts/blob/ae54f5caffc20c2f58c46e8a3c9e2c414fe18813/src/app/components/ContactPlaceholder.js#L202

mKoonrad avatar Nov 06 '19 22:11 mKoonrad

ttag does not offer currently the possibility of mixing jsx and plurals. See https://github.com/ttag-org/ttag/issues/160.

Therefore, for the case of having plural-changing text that goes in bold together with non-bold text, as is the case here and in some other places in mail, I see no better option than what's written in the code already. This approach is also being followed by @Swiip for mail

See also #227

econdepe avatar Dec 01 '19 16:12 econdepe