gosop icon indicating copy to clipboard operation
gosop copied to clipboard

It'd be great to have a gosop compiled with x/crypto/openpgp

Open teythoon opened this issue 1 year ago • 2 comments
trafficstars

I don't know how much the API diverged, and how much work that would be. If we had a gosop to test x/crypto/openpgp with, we could put it into the test suite. Maybe that'd even encourage some users to switch to GopenPGP.

teythoon avatar Mar 27 '24 12:03 teythoon

It'd essentially entail a rewrite (except for the CLI part, of course). Note that GopenPGP is a wrapper around ProtonMail/go-crypto, which is in turn derived from x/crypto/openpgp - so GopenPGP itself shares no API with x/crypto. GopenPGP also provides a much more high-level API than {x/,ProtonMail/go-}crypto, so a SOP implementation using the latter would need to reimplement a bunch of logic from GopenPGP.

It might be easier to build a version of GopenPGP (v2) that uses x/crypto/openpgp. That should not be too much work since ProtonMail/go-crypto is largely backwards compatible with it, though x/crypto/openpgp might be missing some things that GopenPGP uses - but I'm not sure if those parts are critical to the functionality needed by SOP; that might be worth investigating.

twiss avatar Mar 27 '24 18:03 twiss

Thanks for providing the details. I cannot judge how much work that is and what the benefit might be, really, so feel free to close the issue, your call.

teythoon avatar Apr 02 '24 14:04 teythoon