go-crypto
go-crypto copied to clipboard
ProtonMail
add photo api
@izouxv You ignored all the comments that are hidden by default, you need to click "Load more..." or check the Files tab.
This comment was not addressed. I know it didn't exist at the time this PR was opened, so I apologize for the churn, but all new functionality should go in the openpgp/v2 package. Please move the changes (except those in openpgp/packet) there, if you can.
This comment was not addressed. I know it didn't exist at the time this PR was opened, so I apologize for the churn, but all new functionality should go in the openpgp/v2 package. Please move the changes (except those in
openpgp/packet) there, if you can.
ok
In addition to the above, could you please write a brief summary of the changes and additions to the API in the PR description, so that I can include it in the commit message? Currently it's very vague.
In addition to the above, could you please write a brief summary of the changes and additions to the API in the PR description, so that I can include it in the commit message? Currently it's very vague.
ok
@twiss please check again. thank you.
pr commit is: [feat](feat: Add AddPhotos to v2 api.)
Sorry, I meant more like: could you write a short description of the functions you added and what they're for? See https://github.com/ProtonMail/go-crypto/commit/8b3893ee7fca8cf2f8ab27de531011586c2f7b0d for a random (unrelated) example.
Sorry, I meant more like: could you write a short description of the functions you added and what they're for? See 8b3893e for a random (unrelated) example.
my desc is : feat: Add Entity.AddPhotos function to v2 This change introduces a new function, Entity.AddPhotos, and the Entity struct adds a new member variables "Attributes". this enables user avatars encoded in jpeg format please check , thank you