protoschool.github.io icon indicating copy to clipboard operation
protoschool.github.io copied to clipboard

Unnecessary file upload step in MFS - Lesson 9 (Copy a file or directory)

Open Frijol opened this issue 5 years ago • 2 comments

Have a question or suggestion regarding a specific ProtoSchool lesson? Please use this template to share it!

URL of the lesson that's confusing: https://proto.school/#/mutable-file-system/09

What's confusing about this lesson?

This step still calls for an upload of files, but there's no need to do so for this exercise! I know we keep the code for moving files, but it feels pretty weird to still make this 2-step.

Fairly minor nit. Screen Shot 2019-06-21 at 1 53 20 PM

What additional context could we provide to help you succeed?

Remove Step 1 from this lesson?

What other feedback would you like to share about ProtoSchool?

Frijol avatar Jun 21 '19 20:06 Frijol

I'm digging through issues today and love seeing all of your feedback @frijol!

My gut, although I understand why it feels awkward, is that it might be too disruptive to the way our code works to remove, but ccing @zebateira for a second opinion with fresh eyes.

terichadbourne avatar Sep 18 '20 19:09 terichadbourne

It does look awkward to have to upload files that are not needed for this lesson. I guess we went for consistency (building up the solution code) and so that required us to keep the file upload feature in this lesson.

Even so, I'd say it's a useful insight to have: the fact that we can copy files from several places, like uploads and ipfs itself, and then see them together in the same ipfs directory. Although it might not be the case for some users, most of the users should have come from previous lessons with the files already selected to upload.

So I guess it comes down to please all the users by changing this lesson's code solution, or keep the code solution consistent throughout the tutorial. I'm fine with both solutions, but more torn to the latter (current one).

zebateira avatar Sep 21 '20 10:09 zebateira