proof-of-humanity-web icon indicating copy to clipboard operation
proof-of-humanity-web copied to clipboard

Search working badly - Only looks for the nickname and not for names

Open francrubio opened this issue 3 years ago • 3 comments

When using the search box, it only looks for the nickname of the people. This is bad because you can't look for duplicates or even if you're looking for somebody you know.

For example:

I was looking for Agustin Canavas https://app.proofofhumanity.id/profile/0x3150933b4a02dd9b47129e0ac48d352c918ffcc7?network=mainnet

If you look by the exact name, no results. image

if you look for the name only "Agustin" , his profile did not pop up image

francrubio avatar Apr 07 '21 04:04 francrubio

This is due to limitations on using subgraph. Unfortunately to have a decent search engine we'll need to implement a custom backend.

eccentricexit avatar Apr 08 '21 18:04 eccentricexit

@francrubio @eccentricexit @alcercu It also seems like the search distinguishes between upper-case and lower-case characters?

Example: You might get a result for "Agustin", but not for "agustin". Or vice versa.

aahna-ashina avatar Dec 21 '21 15:12 aahna-ashina

Yes, theGraph protocol uses GraphQL, and by the specs of the later one, searches are case-sensitive. A possible solution could be to create an additional field on the subgraph that stores names in lower case, and then we query against that field instead of name (converting the query to lower case too) 🤔 This could be seen as redundant data, though.

alcercu avatar Dec 22 '21 08:12 alcercu