Adam Warner
Adam Warner
Pop it in the `examples` subdirectory, and maybe add a reference to it on the main README page. I think the `pihole/docs` repo is a good target, too.
Pass 1 of this: https://github.com/pi-hole/docker-pi-hole/pull/1366
Great suggestions, some of them in line with thoughts I'm still trying to order in my head :) ## `wget` / `unzip` No problem dropping, unless they are needed by...
> but we still check for updates. Thinking on it, we just need to get the versions when the container is built, and the only update we should be checking...
> Worth the experment! Need to tweak some of the `install` calls, that's fine - I just copy pasted them from the installer in the first place, fully expected things...
Removing `ncurses` broke the `pihole -v ` output. I will add it back in for the time being until we decide the direction we will be going with the version...
> I think `unzip` is not necessary as dependency. Cool, feel free to try it and PR if it works :)
Have just checked my running v6 container and logrotate certainly appears to be working correctly here: ``` dev-v6:/# ls -lah /var/log/pihole total 9.0M drwxr-xr-x 1 pihole pihole 348 Mar 29...
Does anyone in this thread still have problems with the logs not being rotated?
What does your compose file look like? (Also, have you tried the beta v6 image?)