Adam Warner

Results 279 comments of Adam Warner

What if a blocked domain is on multiple adlists? Are we just taking the id/name of the first adlist that we find a match for?

Is it worth potentially making `list_id` return an array?

Agree with Yubi here, I'm unsure of the benefit of showing a link to the first adlist we find the domain in. Lets say this causes the user to rethink...

Lol, I didn't yet check or test the code - and as I didn't see any commits after the conversation.... I guess the old code was FP'd away :)

If I use the array provided in the example (`[ "(^|\.)\.google\.de$", "\.pi-hole\.net$" ]`) I get the following when viewing the query log: ![image](https://github.com/pi-hole/FTL/assets/1998970/2e1bfc30-6959-469e-bf96-d3de917fa3ba)

> this may be more tricky Build the image locally with: ``` docker buildx build src/. --tag ph-development-v6 --no-cache --build-arg FTL_BRANCH=fix/DBimport ``` And then replace the reference to `pihole/pihole:development-v6` with...

> However, it changes a behaviour so maybe someone relies on this behaviour? https://xkcd.com/1172/ I can't say for certain that anyone's install would or would not be affected by this...

I think, to be honest, I'd rather not produce an image that has unbound built into it. However I think it is a good candidate for an example compose file...

Also worth mentioning here that v6 will be an alpine-based container

Feel free to develop and maintain your own unbound images using the suggested configs from docs.pi-hole.net, or whatever config you so wish to use! As far as this repository goes,...