prometheus_client_php icon indicating copy to clipboard operation
prometheus_client_php copied to clipboard

Redis storage uses KEYS for metrics collection

Open jaco opened this issue 2 years ago • 3 comments

KEYS is very expensive command, according to manual:

Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout. Don't use KEYS in your regular application code. If you're looking for a way to find keys in a subset of your keyspace, consider using SCAN or sets.

I saw that there was an attempt to change KEYS to SCAN and performance dropped.

IMO redis storage should use some kind of list/set to keep track of used metrics.

In our deployment, keys command its responsible for 90%+ load of whole redis instance and we use redis storage ONLY for jobs (APCu for http requests).

jaco avatar Nov 19 '22 11:11 jaco