prometheus_client_php icon indicating copy to clipboard operation
prometheus_client_php copied to clipboard

Added basic support for redis sentinel based on https://github.com/Namoshek/laravel-redis-sentinel

Open Jacq opened this issue 7 months ago • 3 comments

Merged and refactor code with from old fork #https://github.com/ml65/prometheus_client_php that supports redis sentinel by updating master address/port options before redis connections.

Jacq avatar Apr 12 '25 11:04 Jacq

Hey, thank you for your work. Would it be possible to add tests based on https://hub.docker.com/r/bitnami/redis-sentinel (see our https://github.com/PromPHP/prometheus_client_php/blob/main/.github/workflows/tests.yml)?

LKaemmerling avatar Apr 14 '25 06:04 LKaemmerling

Hey, thank you for your work. Would it be possible to add tests based on https://hub.docker.com/r/bitnami/redis-sentinel (see our https://github.com/PromPHP/prometheus_client_php/blob/main/.github/workflows/tests.yml)?

Already added some test and performed a full refactor based on a different repo, using phpredis sentinel support. Still need to fix the Redis version matrix test

Jacq avatar Apr 17 '25 18:04 Jacq

Added tests, ready to merge. It was tricky to include Redis sentinel service as redis5 does not support resolve hostname.

Jacq avatar Apr 18 '25 17:04 Jacq