SidewalkWebpage icon indicating copy to clipboard operation
SidewalkWebpage copied to clipboard

Test Code: After Step Event, Upload All Label Data for that Pano ID

Open jonfroehlich opened this issue 8 years ago • 7 comments

Because of the problems we have had in losing data, I was thinking we could do this: after the user registers a step event on a panorama (that is, is about to leave said panorama), as test code, we should re-upload all labels and associated metadata for that panoid and check to make sure we have the same exact data on our backend.

We could then comment this code out once we are confident our fixes work (or just put it in a If DEBUG==True conditional).

jonfroehlich avatar Aug 07 '17 13:08 jonfroehlich

@sbower213, can you write an update on this before you go on vacation please?

jonfroehlich avatar Aug 09 '17 20:08 jonfroehlich

No updates on this issue so far. I started working on it but quickly went back to fixing up my code in #945 to get that ready for testing and merging. Once that code is added to production, it will be much easier to work on this branch, since we need the changes from #937 to be incorporated first.

sbower213 avatar Aug 09 '17 20:08 sbower213

Got it. Thanks.

Sent from my iPhone

On Aug 9, 2017, at 4:42 PM, Steven Bower [email protected] wrote:

No updates on this issue so far. I started working on it but quickly went back to fixing up my code in #945 to get that ready for testing and merging. Once that code is added to production, it will be much easier to work on this branch, since we need the changes from #937 to be incorporated first.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

jonfroehlich avatar Aug 09 '17 21:08 jonfroehlich

@sbower213 I know you are no longer contributing code to this project but could you update this Issue with a breakdown of where we stand on this so someone could come in and possibly finish it up?

jonfroehlich avatar Aug 30 '17 19:08 jonfroehlich

Are we confident that this is no longer an issue @misaugstad? It seems like we should have some test cases setup to ensure that we are not losing any data...

jonfroehlich avatar Jun 26 '19 15:06 jonfroehlich

Ahh yes I had figured that we were confident that we were getting all the data after the close scrutiny of issue #1648 (where we were losing data on page unload). Though upon closer reading, I see that this quite the same thing, and this seems important enough to possibly want dedicated tests.

Do you remember what we are talking about here with losing data?

misaugstad avatar Jun 26 '19 18:06 misaugstad

Yes, I do. This was a critical data loss issue where we were only uploading data after every X events after pano load. This was during your first summer with us. We solved this problem (I believe) but never had a test infrastructure setup to fully validate our solutions.

jonfroehlich avatar Jun 26 '19 20:06 jonfroehlich