opensea-creatures icon indicating copy to clipboard operation
opensea-creatures copied to clipboard

No tests for Creature.sol, CreatureFactory.sol, and others

Open akutruff opened this issue 4 years ago • 0 comments

It looks like there's a lot of missing tests for what looks like sensitive code pertaining to ownership.

This may be a separate issue but I've seen functions that mention hacks. These aren't tested and it would be comforting to know in detail why these aren't following the standard.

    /**
     * Hack to get things to work automatically on OpenSea.
     * Use transferFrom so the frontend doesn't have to worry about different method names.
     */
    function transferFrom(
        address _from,
        address _to,
        uint256 _tokenId
    ) public {
        mint(_tokenId, _to);
    }

    /**
     * Hack to get things to work automatically on OpenSea.
     * Use isApprovedForAll so the frontend doesn't have to worry about different method names.
     */
    function isApprovedForAll(address _owner, address _operator)
        public
        view
        returns (bool)
    {
        if (owner() == _owner && _owner == _operator) {
            return true;
        }

        ProxyRegistry proxyRegistry = ProxyRegistry(proxyRegistryAddress);
        if (
            owner() == _owner &&
            address(proxyRegistry.proxies(_owner)) == _operator
        ) {
            return true;
        }

        return false;
    }

    /**
     * Hack to get things to work automatically on OpenSea.
     * Use isApprovedForAll so the frontend doesn't have to worry about different method names.
     */
    function ownerOf(uint256 _tokenId) public view returns (address _owner) {
        return owner();
    }

akutruff avatar Mar 25 '21 19:03 akutruff