opensea-creatures icon indicating copy to clipboard operation
opensea-creatures copied to clipboard

remove "export" from .env.sample

Open Paul-Browne opened this issue 3 years ago • 1 comments

.env files should just be like

INFURA_KEY=
MNEMONIC=
OWNER_ADDRESS=
NFT_CONTRACT_ADDRESS=
FACTORY_CONTRACT_ADDRESS=
NETWORK=rinkeby

Also no need for the quotation ("") marks

Paul-Browne avatar Dec 14 '21 10:12 Paul-Browne

My opinion is that we should retain export in .env.sample . Upon checking the difference between the 2 ways , I infer that

  • Without Export : the Variable is called a Shell Variable
  • With Export : the. variable is a Environment Variable and Terminal treats it as an Environment Variable

Also, In my experience i have seen environment variables exported using 'export' command in the Config File. Hence I formed my opinion .

humanwhoexplores avatar Dec 31 '21 07:12 humanwhoexplores