mirador-annotations icon indicating copy to clipboard operation
mirador-annotations copied to clipboard

React 16/17 conflict

Open chchch opened this issue 3 years ago • 4 comments

Hi,

I can't seem to build this —mirador currently requires react@^16.8.3, which is conflicting with mirador-annotations which requires react@^17.0.

Thanks!

chchch avatar Nov 12 '21 14:11 chchch

I ran into this myself. Is it safe to use the --force flag, or would that break things?

D-Groenewegen avatar Oct 14 '22 09:10 D-Groenewegen

I actually did manage to compile it eventually... I guess I used --force? This is what the dependencies in my package.json file look like:

  "dependencies": {
    "mirador": "^3.3.0",
    "mirador-annotations": "^0.5.0",
    "mirador-image-tools": "^0.11.0",
    "react": "^17.0.2",
    "react-dom": "^17.0.2",
    "url": "^0.11.0"
  }

chchch avatar Oct 14 '22 09:10 chchch

[Edited - spoke to soon]

Unfortunately no luck on my end.

D-Groenewegen avatar Oct 14 '22 09:10 D-Groenewegen

We got it working with version 0.4.0 of this plugin, which use react 16

lpoujade avatar Nov 07 '22 15:11 lpoujade