ProjectKorra icon indicating copy to clipboard operation
ProjectKorra copied to clipboard

Deprecated playAirbendingParticles.

Open DomiRusz24 opened this issue 2 years ago • 4 comments

I chose to recreate the function, with an added on CoreAbility argument, instead of a method, cause it would have to have its name changed, therefore breaking the playXbendingParticles scheme. The faster this is done, the better for all of us particle maniacs.

Misc. Changes

> Deprecated playAirbendingParticles, playSandbendingParticle, playFocusWaterEffect, and playLightningbendingParticles.
> Updated all of these function calls to reflect the change
> Added JavaDocs there where they were absent.

DomiRusz24 avatar Oct 08 '22 11:10 DomiRusz24

Have you done this for every single element that has a playParticles method?

StrangeOne101 avatar Oct 09 '22 00:10 StrangeOne101

Have you done this for every single element that has a playParticles method?

This change has been done only to: static playXParticles(), that don't in any way shape or form require a CoreAbility argument. Yes, all static playXParticles() have been converted to playXParticles(this, ...) to reflect the change. The old functions still stand, but they are depreciated (Both as in annotation, and in JavaDoc). This change will not break compatibility, but will allow devs in the long run to edit particles emitted by a player, per player. Cosmetics of sorts. MiscChanges lists all playXParticles this has been done for. + made WaterManip use playFocusWaterEffect

DomiRusz24 avatar Oct 09 '22 12:10 DomiRusz24

@DomiRusz24 Correct me if I am wrong, but you are proposing this change so that in, the future, it would be possible to actually use the given CoreAbility instances? How would you imagine that being done?

ChristopherWMM avatar Oct 16 '22 19:10 ChristopherWMM

@ChristopherWMM It has already been done by me. Custom particle system, were based on the players choice, a different particle would show up. For example, instead of Air particles, you could have hearts. In my implementation, I have created a "ParticleSpawnEvent" in the PK itself (custom PK jar), that I use in a seperate plugin that uses it to modify them, based on what a player chooses. This is also useful for "bedrock-ish" servers, that have bugged particles (for air specially), cause you can also by default change the effect (to a white coloured particle for example)

DomiRusz24 avatar Oct 16 '22 21:10 DomiRusz24