solutions
solutions copied to clipboard
ProjectDrawdown
Current Model Test Failures
The following models currently have test failures, all on the same unit adoption test: bikeinfrastructure, buildingautomation, composting, concentratedsolar, electricbikes, greenroofs, masstransit, solarhotwater, walkablecities. Since they previously worked, and are all failing at the same location, it is probably a recent bug (likely having to do with replacing xlrd with openpyxl).
The current goal is to look into test failures and see if some can be easily fixed. This should be a limited time effort of a week to a week and a half.
In bikeinfrastructure the issue is in pds.ua.soln_pds_cumulative_funits()
The values for World are correct. In the other regions the expected values are all 0, because those are undefined in the excel. However, Python puts values for the other regions starting in the year 2018. Those values come from the ref_base_adoption variable in the ac .json files.
Not sure what's the best fix here.
Usually it turns out that different spreadsheets did things differently, and the extractor code tries to match that by adding in what I call quirks parameters (like bug_cfunits_double_count). But the extractor may get it wrong and set the wrong value. Or in some cases, this is a new quirk that neither the extractor nor the code know how to handle.
If there are existing relevant quirks parameters, looking at those and trying different values may help. Or, to see if this is a new quirk, the multi-extract tool can be very useful. It will show you the same bit of Excel from multiple spreadsheets so you can quickly compare the formulas and see if they differ between different spreadsheets. If they do, then we may need to add a new quirks parameter to handle that. (I think you have access to the entire set of spreadsheets -- if not, let me know.)
This particular error ('Q135:AA181') is actually the error we see in quite a few of the failures, so figuring this out for one solution could potentially fix many problems.
-- Denise Draper @.***
On Tue, Sep 14, 2021, at 6:31 AM, Daniel Müller-Komorowska wrote:
In bikeinfrastructure the issue is in
pds.ua.soln_pds_cumulative_funits()The values for World are correct. In the other regions the expected values are all 0, because those are undefined in the excel. However, Python puts values for the other regions starting in the year 2018. Those values come from theref_base_adoptionvariable in the ac .json files. Not sure what's the best fix here.— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/issues/317#issuecomment-919154133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAMTWRSXR4KMIZVEOZ4JTUB5FCNANCNFSM5ASSZIGQ.
The list in the issue was correct at that time, but probably isn't very relevant now. The current test results are what to go by.
-- Denise Draper @.***
On Thu, Sep 16, 2021, at 12:52 PM, Daniel Müller-Komorowska wrote:
concentratedsolar passes testing on my end without any changes.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/ProjectDrawdown/solutions/issues/317#issuecomment-921199332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAMTQYHOBGC6ZCTTX4F33UCJDHDANCNFSM5ASSZIGQ.