solutions icon indicating copy to clipboard operation
solutions copied to clipboard

Net Profit Margin calcs

Open DentonGentry opened this issue 5 years ago • 5 comments

In the Excel models the Land solutions produce Net Profit Margin results as an output, and it is believed that even non-Land solutions could use this though the Excel models do not do so. Net Profit Margin is not currently implemented in the Python model, it needs to be added.

DentonGentry avatar Feb 08 '20 15:02 DentonGentry

The public versions of the Excel files are checked into the repository. We removed them once tests/test_excel_integration.py evolved to the point of not needing them any more, as they were quite large, but they are still in the history. They are stored using git LFS so they don't take up local disk space for people who check out HEAD.

git revert dcad0e37763807602e1220c9477dd24667127aa4

will restore the deleted Excel files. Look in solution//testdata/.xlsm to find them. If you do revert this to get the Excel files back, please make sure not to include it in a future pull request as this would substantially increases the local disk space needed for others who check out the repo.

If you revert this commit but solution//testdata/.xlsm are tiny little files, that probably means you need to git lfs install before re-doing the revert. The Excel files reside in Large File Storage.

The Land solutions, like solution/conservationagriculture or solution/regenerativeagriculture, have a Sheet in their Excel file named "Net Profit Margin" and this part of the model has not yet been implemented in the Python model.

Looking at one of the other sheets which has been, like Operating Cost or First Cost, might help in making sense of what needs to be done for Net Profit Margin. There are some extremely raw notes about Operating Cost and its conversion to Python which might be useful.

DentonGentry avatar Mar 28 '20 23:03 DentonGentry

Based on Twitter DM conversations, there is a developer looking in to this issue. Before someone else begins work on this, please ping me and I can check in with them.

DentonGentry avatar May 21 '20 01:05 DentonGentry

We believe Josh is working on this. ;-)

colleenskemp avatar Jul 12 '21 19:07 colleenskemp

I'll try to do this one.

4dahalibut avatar Jul 22 '21 21:07 4dahalibut

It's all yours :-)

denised avatar Jul 22 '21 21:07 denised