Project-OSRM
Update OSRM.RoutingGUI.js
The angry message was intentionally added. The original implementation (when osmbugs and just josm were used) also adjusted the zoom level appropriately, but this left users confused why they now see a different section of the map.
Oops, never saw this reply. My experience has been that you almost always get shown the message, and it's just annoying and uninformative.
@DennisOSRM, any comments on that request? Do you have feedback from other users?
@DennisSchiefer Do I read this right, that the patch doesn't give any hint that it didn't load anything into Josm?
I see the point that the modal dialog is nagging people. On the other hand, there should be feedback. Ideally, the UI shows something that goes away on its own after a moment.
We could use a notification instead, like the ones appearing on top of the screen with tooltips?
Sounds good. Is it easy to make it disappear automatically after lets say two seconds?
Currently not implemented as the tooltips were intended to stay on top of the page until clicked away. But at least they are not as nagging as the exclusive alert box. Also, do you propose to only show this message and not open the editor, or still open the editor so that the user sees the message only when coming back to the osrm website?
I'd say to only open the editor when data is loaded. Otherwise, people will be easily confused where the error occurred or what it was.
One question for the tooltips: consider that there is already a tool tip open with a different message. Would it change its contents or would a new one open on top?
Our current tooltip appear after a timer has elapsed. If a tooltip is currently visible, the timer is restarted - but these tooltips are only to guide new users. Interactive tooltips that pop up due to user interaction are not specifically implemented. Using the current code base, they would simply overwrite a currently visible tooltip.
Using the current code base, they would simply overwrite a currently visible tooltip.
Sounds good. If it is an easy implementation, I'd say let's do it this way.
Just thought I'd comment that I use Potlatch 2. It sounds like you guys use JOSM, so we're probably seeing very different user experiences.
@stevage Not sure I get your concerns here. Can you elaborate on the differences you are thinking about?
Well, I haven't used JOSM, so I don't know what that experience looks like, but for me with Potlatch2, it's like this.
Current behaviour:
- Click to edit map at some reasonable zoom level
- See message "You need to zoom in more to edit" (or whatever it is)
- Click to close message, zoom in a bit more, go to step 1.
What's most annoying is that if you just went straight to openstreetmap.org, you could edit at exactly that zoom level and location.
Changed behaviour:
- Click to edit map at some reasonable zoom level
- Start editing. (You probably don't even notice that OSRM zoomed the map in a bit more for you.)
If you find this so confusing, could we compromise:
- Click to edit map at some reasonable zoom level
- See message "You're at a low zoom level, so we're just going to zoom in a bit more."
- Start editing.