osrm-backend
osrm-backend copied to clipboard
Fix Node.js binding path to match node-pre-gyp versioning
Fix #7272 by:
- Update BINDING_DIR from
lib/bindingtolib/binding_napi_v8to align with node-pre-gyp's versioning conventions - Add
file(MAKE_DIRECTORY)to create the binding directory during CMake configuration - Update all references in lib/index.js, package.json, CI scripts, and documentation
Tasklist
- [x] CHANGELOG.md entry (How to write a changelog entry)
- [ ] update relevant Wiki pages
- [ ] add tests (see testing documentation)
- [ ] review
- [ ] adjust for comments
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?
Hi @DennisOSRM and @SiarheiFedartsou please take a look at my fix
Thanks for this @afarber. I wasted so much time trying to understand what was going on!