osrm-backend icon indicating copy to clipboard operation
osrm-backend copied to clipboard

Fix Node.js binding path to match node-pre-gyp versioning

Open afarber opened this issue 1 month ago • 2 comments

Fix #7272 by:

  • Update BINDING_DIR from lib/binding to lib/binding_napi_v8 to align with node-pre-gyp's versioning conventions
  • Add file(MAKE_DIRECTORY) to create the binding directory during CMake configuration
  • Update all references in lib/index.js, package.json, CI scripts, and documentation

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

afarber avatar Nov 20 '25 18:11 afarber

Hi @DennisOSRM and @SiarheiFedartsou please take a look at my fix

afarber avatar Nov 22 '25 15:11 afarber

Thanks for this @afarber. I wasted so much time trying to understand what was going on!

YoelRidgway avatar Dec 09 '25 00:12 YoelRidgway