osrm-backend icon indicating copy to clipboard operation
osrm-backend copied to clipboard

pass flags into process_segment

Open mattwigway opened this issue 1 year ago • 2 comments

Issue

This partially addresses #6145, by making the extractor edge flags available to process_segment as segment.flags. This allows accessing road classification, start point, etc. in process_segment. I'm using it by tagging bridges/tunnels as non-startpoints and then not applying elevation weighting to them since they are flat (ish) where I am but often cross deep valleys.

I'm not quite sure how to write an automated test for this. Maybe a profile that uses the flags information in a cucumber test?

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

mattwigway avatar Jul 20 '23 17:07 mattwigway

I'm having some trouble getting the Cucumber tests running to finish this, which seems to have to do the node OSRM library. It looks like it's trying to find it locally, failing, and then trying to grab it from github, which fails as well since it's a non-release version. Do I need to do something to build the Node.js bindings locally?

mattwigway avatar Nov 29 '23 19:11 mattwigway

Okay, I figured out the Cucumber tests and added a test that confirms that segment flags get passed through to process_segment. @mjjbell let me know if anything else is needed and my apologies for the delay.

mattwigway avatar Dec 12 '23 17:12 mattwigway

@mjjbell I added the changelog entry and rebased to avoid merge conflicts in changelog. Thanks!

mattwigway avatar Apr 03 '24 19:04 mattwigway