osrm-backend icon indicating copy to clipboard operation
osrm-backend copied to clipboard

Take stop and give way signs into account during routing

Open SiarheiFedartsou opened this issue 3 years ago • 3 comments

Issue

Done mainly using https://github.com/Project-OSRM/osrm-backend/pull/6153/, https://github.com/Project-OSRM/osrm-backend/commit/d1b9dffdd10652a35347f77a59ac5c765be95d51 and https://github.com/Project-OSRM/osrm-backend/pull/4828 (which also handles stop=all which I don't do here) as a reference

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

SiarheiFedartsou avatar Oct 27 '22 19:10 SiarheiFedartsou

Perhaps the other thing to consider is the navigation guidance. I didn't really think about it in #6153 as traffic signals already existed. Adding stop/give-way signs is something that the guidance code should be aware of.

In fact, given I didn't change any of it, I suspect it doesn't work with traffic signal directions either.

mjjbell avatar Oct 28 '22 14:10 mjjbell

@mjjbell @DennisOSRM can we may be make second round of review here?

SiarheiFedartsou avatar Nov 08 '22 21:11 SiarheiFedartsou

This PR seems to be stale. Is it still relevant?

github-actions[bot] avatar Jul 08 '24 20:07 github-actions[bot]