osrm-backend icon indicating copy to clipboard operation
osrm-backend copied to clipboard

5.27 Release?

Open mjjbell opened this issue 2 years ago • 7 comments

Given the recent activity with a number of fixes/improvements hitting master, it might be worth making a new release.

Here are some additional changes that I think should also be included:

  • [ ] Finalising the CI/build changes & Mason to Conan switch #6300 #6324
  • [ ] Updating the development docs to reflect the above changes & general tidying #6150
  • [x] Publish Windows Node builds node-pre-gyp has Windows support. #6334
  • [x] Publish Apple Silicon builds #6360
  • [ ] Fixes for debug build assertions #6215 #6218
  • [x] Snapping improvements/fixes to via restrictions #5953 #6339
  • [x] Support directional traffic lights #6153

Any other suggestions/thoughts?

mjjbell avatar Aug 23 '22 16:08 mjjbell

Publish Windows Node builds?

It effectively means configuring build with ENABLE_NODE_BINDINGS=ON on Windows and packaging resulting module on releases?

SiarheiFedartsou avatar Aug 23 '22 21:08 SiarheiFedartsou

@mjjbell Btw do you have access to Docker Hub? I am not sure how our release process is configured, but would be great to push it there too(https://github.com/Project-OSRM/osrm-backend/issues/6231)

SiarheiFedartsou avatar Aug 23 '22 21:08 SiarheiFedartsou

It effectively means configuring build with ENABLE_NODE_BINDINGS=ON on Windows and packaging resulting module on releases?

Yes, hopefully we can just reuse the Node package/publish step

Btw do you have access to Docker Hub? I am not sure how our release process is configured, but would be great to push it there too(https://github.com/Project-OSRM/osrm-backend/issues/6231)

No, we can no longer publish to Docker Hub due to a change in the TOS (hence the missing version). We've switched to using Github Packages container registry (#6138), so it will publish here in the next release. That's something else that we will need to update in the docs.

mjjbell avatar Aug 23 '22 21:08 mjjbell

Btw I would also think about publishing Node module for Apple Silicon Macs.

SiarheiFedartsou avatar Aug 24 '22 09:08 SiarheiFedartsou

It's not possible yet with Github hosted runners: https://github.com/actions/runner-images/issues/2187

mjjbell avatar Aug 24 '22 11:08 mjjbell

It's not possible yet with Github hosted runners: actions/runner-images#2187

AFAIR we can cross-compile for M1 on old Macs. I'll try to experiment with it at some day.

SiarheiFedartsou avatar Aug 24 '22 11:08 SiarheiFedartsou

It's not possible yet with Github hosted runners: actions/runner-images#2187

AFAIR we can cross-compile for M1 on old Macs. I'll try to experiment with it at some day.

Well, it is possible: https://github.com/Project-OSRM/osrm-backend/pull/6360

Just need to clean it up and figure out how to properly build release package.

SiarheiFedartsou avatar Sep 10 '22 20:09 SiarheiFedartsou

Release candidate is out. Looks like all the new deployment infrastructure is working :tada:

mjjbell avatar Oct 06 '22 22:10 mjjbell