osrm-backend
osrm-backend copied to clipboard
Project-OSRM
Migrate to modern TBB version
Issue
closes https://github.com/Project-OSRM/osrm-backend/issues/6297 closes https://github.com/Project-OSRM/osrm-backend/issues/6181 closes https://github.com/Project-OSRM/osrm-backend/issues/6087
Tasklist
- [ ] CHANGELOG.md entry (How to write a changelog entry)
- [ ] update relevant Wiki pages
- [ ] add tests (see testing documentation)
- [ ] review
- [ ] adjust for comments
- [ ] cherry pick to release branch
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?
I see that Windows build fails. Most likely because it uses old TBB stored on wolt.com. What I am thinking about is may be migrate it to use Conan too - should be probably a bit better approach rather than try to find someone from Wolt to update it now... Another option is to simply install TBB to the system just like I did for Linux/Mac.
I see that Windows build fails. Most likely because it uses old TBB stored on wolt.com. What I am thinking about is may be migrate it to use Conan too - should be probably a bit better approach rather than try to find someone from Wolt to update it now... Another option is to simply install TBB to the system just like I did for Linux/Mac.
Btw worth considering migration to GitHub Actions for Windows CI 🤔
Agreed, adding a Windows build to Github Actions CI and killing off the old one is probably the direction to take and will make it easier to perform library upgrades. IIRC the motivation for moving to C++17 was to take advantage of the STL parallel algorithms. Removing TBB completely could solve these problems too, although might require a lot of surgery.
IIRC the motivation for moving to C++17 was to take advantage of the STL parallel algorithms. Removing TBB completely could solve these problems too, although might require a lot of surgery.
Yep, but it turned out that there are a lot of compilers that still do not support STL parallel algorithms from C++17 in 2022. One example is Apple Clang. I haven't dug deep here though, but lets first migrate TBB in order to unblock local builds without Conan - it seems to be easier problem anyway.
@mjjbell I think I am done with it, so please take a look when you have a chance