monai-deploy-app-sdk icon indicating copy to clipboard operation
monai-deploy-app-sdk copied to clipboard

[FEA] Update Docker image to resolve permission issue

Open gigony opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. Follow up change/comments for:

  • https://github.com/Project-MONAI/monai-deploy-app-sdk/pull/168
  • https://github.com/Project-MONAI/monai-deploy-app-sdk/pull/168#discussion_r725550615
  • https://github.com/Project-MONAI/monai-deploy-app-sdk/pull/168#discussion_r725551221
  • https://github.com/Project-MONAI/monai-deploy-app-sdk/pull/168#pullrequestreview-775615834

Need to figure out the general solution.

Describe the solution you'd like

The general solution could be involved in using a tool like gosu (https://github.com/tianon/gosu) and changing folder permission at launch time.

May can refer to Jupyter notebook docker’s solution (https://github.com/jupyter/docker-stacks).


This is how Jupyter notebook docker workaround the user/permission issue.

  • https://jupyter-docker-stacks.readthedocs.io/en/latest/
  • https://github.com/jupyter/docker-stacks/blob/master/base-notebook/Dockerfile

It calls this script to fix permission settings:

  • https://github.com/jupyter/docker-stacks/blob/master/base-notebook/start.sh#L67

Another info: Kubeflow serving Jupyterlab

  • https://www.kubeflow.org/docs/components/notebooks/container-images/

gigony avatar Nov 23 '21 18:11 gigony

Team, I will recreate the steps shown in the workaround for this issue, but this is something that has been tracked for a few months now. Ultimately, most of our customers that interact directly with building a MAP and specifically that need to deploy the application will want a solution that doesn't require installing additional tools or prevents deployment from succeeding due to permissions. In other cases, the devs may not have full control of the machine to be able to apply the workarounds and in production environments it will be even less likely that specific users will exist or be created (e.g. Monai_user or 1001).

slbryson avatar Jan 12 '22 21:01 slbryson

@KavinKrishnan Please help with this issue. I wonder to what extent does the following PR solves the issue here?

  • https://github.com/Project-MONAI/monai-deploy-app-sdk/pull/199

gigony avatar Jan 18 '22 22:01 gigony