MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard

Doc for `rotate_range` indicates the wrong sign

Open maxime915 opened this issue 11 months ago • 0 comments

Hello,

I think there is an extra minus sign in the doc for the first value of the rotate_range parameter.

https://github.com/Project-MONAI/MONAI/blob/e538f7fd9e55c0fd0e67a4d4af2f69c6eb5b947e/monai/transforms/spatial/array.py#L1809

The method _get_rand_param uses the range without any minus sign added to the first argument.

https://github.com/Project-MONAI/MONAI/blob/e538f7fd9e55c0fd0e67a4d4af2f69c6eb5b947e/monai/transforms/spatial/array.py#L1864

If you agree that this is just a documentation issue, I'd be happy to search for other transform having the same issue (RandAffine and RandAffined seem to have the same issue) and create a PR to remove the extra signs.

Best

maxime915 avatar Feb 14 '25 08:02 maxime915