MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard
verified publisher icon Project-MONAI

8166 Add .py properties file support for BundleWorkflow

Open yiheng-wang-nv opened this issue 1 year ago • 2 comments

Fixes #8166 .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • [x] Non-breaking change (fix or new feature that would not break existing functionality).
  • [ ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [ ] New tests added to cover the changes.
  • [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [ ] In-line docstrings updated.
  • [ ] Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv avatar Oct 23 '24 05:10 yiheng-wang-nv

I also do some refactor in this PR: https://github.com/Project-MONAI/MONAI/pull/8151. If it's a urgent request, we can merge this PR first and discuss more details later otherwise we can leave it here and after discussion let's combine these two prs. Thanks.

KumoLiu avatar Oct 23 '24 05:10 KumoLiu

I also do some refactor in this PR: #8151. If it's a urgent request, we can merge this PR first and discuss more details later otherwise we can leave it here and after discussion let's combine these two prs. Thanks.

Thanks, It's not urgent as MONAI 1.4 is released, we can discuss more details later

yiheng-wang-nv avatar Oct 23 '24 06:10 yiheng-wang-nv

@KumoLiu when would be the timeline for the next MONAI minor release? It would be great if we can include this MR in the next PyPI distribution. Thanks

bhashemian avatar Oct 23 '24 19:10 bhashemian

@KumoLiu when would be the timeline for the next MONAI minor release? It would be great if we can include this MR in the next PyPI distribution. Thanks

Hi @drbeh, currently, we do not have plans to release a minor version. Can discuss about it later. Thanks.

KumoLiu avatar Oct 24 '24 06:10 KumoLiu

I also do some refactor in this PR: #8151. If it's a urgent request, we can merge this PR first and discuss more details later otherwise we can leave it here and after discussion let's combine these two prs. Thanks.

Thanks, It's not urgent as MONAI 1.4 is released, we can discuss more details later

Hi @yiheng-wang-nv, the relevant refactor pr has been merged. Could you please resolve the conflict and add relevant tests? Then this pr can be reviewed and merged. Thanks.

KumoLiu avatar Nov 27 '24 10:11 KumoLiu