MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard
verified publisher icon Project-MONAI

Add Average Precision to metrics

Open thibaultdvx opened this issue 1 year ago • 2 comments

Fixes #8085.

Description

Average Precision is very similar to ROCAUC, so I was very much inspired by the ROCAUC implementation. More precisely, I created:

  • AveragePrecisionMetric and compute_average_precision in monai.metrics,
  • a handler called AveragePrecision in monai.handlers,
  • three unittest modules: test_compute_average_precision.py, test_handler_average_precision.py and test_handler_average_precision_dist.py.

I also modified the docs to mention Average Precision.

Types of changes

  • [x] Non-breaking change (fix or new feature that would not break existing functionality).
  • [ ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [x] New tests added to cover the changes.
  • [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [x] In-line docstrings updated.
  • [x] Documentation updated, tested make html command in the docs/ folder.

thibaultdvx avatar Sep 17 '24 09:09 thibaultdvx

/build

thibaultdvx avatar Oct 21 '24 07:10 thibaultdvx

hi @KumoLiu, could you please have a look at this PR?

thibaultdvx avatar Oct 21 '24 07:10 thibaultdvx

Hi @thibaultdvx we've updated our tests with a directory structure, if you could please look over comments and update where your test files are we can come back to this PR. Thanks!

ericspod avatar Feb 12 '25 14:02 ericspod

Hi @ericspod @KumoLiu, sorry for the absence. I got work and forgot this PR. I'll get right on it!

thibaultdvx avatar Feb 13 '25 08:02 thibaultdvx

@ericspod @KumoLiu ready for review. I don't understand the failing in CI tests, but I'm not sure it is related to my PR.

thibaultdvx avatar Feb 13 '25 14:02 thibaultdvx

Hi @thibaultdvx I'm going to merge recent changes into your branch and see if that sorts the test issues, I don't think it was related to PR either.

ericspod avatar Feb 18 '25 16:02 ericspod

I think this is good to go now, @KumoLiu if you could please trigger blossom, thanks.

ericspod avatar Feb 18 '25 17:02 ericspod

/build

KumoLiu avatar Feb 19 '25 05:02 KumoLiu

Hi @thibaultdvx, please help fix the format issue: https://github.com/Project-MONAI/MONAI/actions/runs/13406057032/job/37446075381?pr=8089 Then I will help trigger the test again, thanks!

KumoLiu avatar Feb 19 '25 05:02 KumoLiu

/build

KumoLiu avatar Feb 20 '25 09:02 KumoLiu