MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard

Add MedNext implementation

Open surajpaib opened this issue 1 year ago • 6 comments

Fixes #7786

Description

Added MedNext architectures implementation for MONAI.

Since a lot of the code is heavily sourced from the original MedNext repo, https://github.com/MIC-DKFZ/MedNeXt, I wanted to check if there is an attribution policy with regarded to borrowed source code. I've added a derivative notice bellow the monai copyright comment. Let me know if this needs to be changed.

The blocks have been taken almost as is but the network implementation has been changed largely to allow flexible blocks and follow MONAI segresnet styling.

Types of changes

  • [x] Non-breaking change (fix or new feature that would not break existing functionality).
  • [ ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [x] New tests added to cover the changes.
  • [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [x] In-line docstrings updated.
  • [ ] Documentation updated, tested make html command in the docs/ folder.

surajpaib avatar Aug 08 '24 18:08 surajpaib

Can't it be usefull to adapt the factory functions of create_mednext_v1 script inside your mednext.py script in order to implement basic configurations of the models in order to compare with the reference paper ?

rcremese avatar Aug 14 '24 12:08 rcremese

Thanks for the comments @johnzielke and thank you for the updates @rcremese. I'll update my branch to dev and look through the changes in your PR asap.

surajpaib avatar Aug 27 '24 14:08 surajpaib

@KumoLiu This implementation should be ready now. Please let me know if you have any comments

surajpaib avatar Sep 28 '24 02:09 surajpaib

@KumoLiu Added.

Do you think there would be interest to add this as a candidate for Auto3DSeg? I refer to this paper for its performance benchmarking: https://arxiv.org/abs/2404.09556

surajpaib avatar Oct 03 '24 15:10 surajpaib

Do you think there would be interest to add this as a candidate for Auto3DSeg? I refer to this paper for its performance benchmarking: https://arxiv.org/abs/2404.09556

Thank you for bringing this up, it's an interesting suggestion. I believe it could be worthwhile to consider this as a potential candidate for Auto3DSeg. However, before moving forward, I would appreciate hearing others' thoughts and insights on whether this aligns with the current goals and roadmap for Auto3DSeg. cc @mingxin-zheng @dongyang0122 @Nic-Ma @myron

KumoLiu avatar Oct 04 '24 14:10 KumoLiu

Great work @surajpaib ! any plans on when we're gonna be able to get this into main?

mrcolo avatar Oct 10 '24 19:10 mrcolo

Hi @KumoLiu, any update on merging this?

We can maybe have a separate issue to discuss Auto3DSeg integration then

surajpaib avatar Nov 08 '24 18:11 surajpaib

/build

KumoLiu avatar Nov 11 '24 05:11 KumoLiu

Hi @KumoLiu, any update on merging this?

Hi @surajpaib, I noticed there are still several open comments. Do you plan to address these, or would it be easier just to respond if you don't intend to make updates? Thanks!

KumoLiu avatar Nov 11 '24 08:11 KumoLiu

@KumoLiu I've closed the comments as most of them have been addressed over modifications made by @rcremese. Also addressed a few that weren't.

surajpaib avatar Nov 11 '24 17:11 surajpaib

/build

KumoLiu avatar Nov 12 '24 03:11 KumoLiu

/build

KumoLiu avatar Nov 13 '24 05:11 KumoLiu