MONAI icon indicating copy to clipboard operation
MONAI copied to clipboard

Add function in monai.transforms.utils.py

Open ytl0623 opened this issue 1 year ago • 6 comments

Fixes #6704

Description

Combined map_classes_to_indices and generate_label_classes_crop_centers to a single function map_and_generate_sampling_centers in monai.transforms.utils.py.

Types of changes

  • [x] Non-breaking change (fix or new feature that would not break existing functionality).
  • [ ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [ ] New tests added to cover the changes.
  • [ ] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ ] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [ ] In-line docstrings updated.
  • [ ] Documentation updated, tested make html command in the docs/ folder.

ytl0623 avatar Apr 25 '24 09:04 ytl0623

cc @Yu0610

ytl0623 avatar Apr 25 '24 12:04 ytl0623

Hi @KumoLiu and @ericspod, Could you please help me review the PR or give some tips to solve the issue?

Thanks in advance!

ytl0623 avatar Apr 25 '24 19:04 ytl0623

Hi @ytl0623, thanks for the quick update. Please take a look at the ci error. Thanks! https://github.com/Project-MONAI/MONAI/actions/runs/8861728836/job/24333913325?pr=7712#step:8:12539

KumoLiu avatar Apr 28 '24 03:04 KumoLiu

Hi @KumoLiu and @ericspod,

@Yu0610 and I just added a unit test and modified some bugs. Please help us review the codes.

Thanks in advance!

ytl0623 avatar May 14 '24 14:05 ytl0623

Hi, @ericspod and @KumoLiu Please review my code if you have free time. Thank you very much!

ytl0623 avatar May 17 '24 13:05 ytl0623

Hi @KumoLiu, Could you please help review codes? Thanks a lot!

ytl0623 avatar May 19 '24 11:05 ytl0623

/build

KumoLiu avatar May 21 '24 06:05 KumoLiu